Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have workflow engine test suites run all flows #1743

Open
Andrew-S-Rosen opened this issue Feb 22, 2024 · 0 comments
Open

Have workflow engine test suites run all flows #1743

Andrew-S-Rosen opened this issue Feb 22, 2024 · 0 comments
Labels

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Feb 22, 2024

What new feature would you like to see?

We should figure out some way to refactor the workflow engine test suites so they run every flow. This will help catch bugs earlier, like #1742. The challenge is we want to avoid copy/paste, but they all are called in different ways, e.g. Client() for Dask, .result() calls for some and not others. Still, I'd rather do copy/paste than have untested code altogether.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Have workflow engine test suites run all tests Have workflow engine test suites run all jobs and flows Feb 24, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Have workflow engine test suites run all jobs and flows Have workflow engine test suites run all flows Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant