Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple never disappears after click and drag #21

Open
ma7moudat opened this issue Jun 13, 2018 · 11 comments
Open

Ripple never disappears after click and drag #21

ma7moudat opened this issue Jun 13, 2018 · 11 comments

Comments

@ma7moudat
Copy link

When using the default mousedown event, if the user clicks on the rippled element and (without releasing) drags the cursor outside the element, the ripple just stays there and doesn't disappear like it's supposed to.

Codepen example:
https://codepen.io/7oot/pen/OEgmML

After a few clicks & drags, you'd get multiple ripple containers stacked on top of each other and all disappear after a normal click & release.

ma7moudat pushed a commit to ma7moudat/vue-ripple-directive that referenced this issue Jun 13, 2018
@Lavrend
Copy link

Lavrend commented Aug 7, 2018

This also happens when you just right-click

@ppsirius
Copy link

Any plan to fix this issue?

@kgrosvenor
Copy link

Yep, this is an issue and ideas?

@ma7moudat
Copy link
Author

I think I'll give it a go over the weekend

@kgrosvenor
Copy link

Awesome, with that final touch this directive will be ace

@ma7moudat
Copy link
Author

ma7moudat commented Jul 15, 2019

looks like it's been fixed here
https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files
but it doesn't look like it's gonna get merged :(

@RedBlueKoi
Copy link

@ma7moudat oh, well. Still not merged =(

@2ju2
Copy link

2ju2 commented Mar 27, 2020

Was this ripple.js file not reflected in the latest version?
https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files

@RedBlueKoi
Copy link

@2ju2 nop, still waiting for merge. Looks like this project is dead. Maybe I'll fork the lib and apply this change for myself.

@amirhossein-fzl
Copy link

looks like it's been fixed here
https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files
but it doesn't look like it's gonna get merged :(

Your changes to the button tag will not work

@amirhossein-fzl
Copy link

amirhossein-fzl commented Nov 18, 2020

I solved this problem. Hoping the author will merge my changes into the project.

https://github.com/PygmySlowLoris/vue-ripple-directive/pull/31/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants