Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all python-crfsuite models from PyThaiNLP #655

Open
wannaphong opened this issue Feb 18, 2022 · 4 comments
Open

Remove all python-crfsuite models from PyThaiNLP #655

wannaphong opened this issue Feb 18, 2022 · 4 comments
Assignees
@wannaphong
Labels
Hacktoberfest for Hacktoberfest event refactoring a technical improvement which does not add any new features or change existing features.
Projects
PyThaiNLP
Milestone
Future

Comments

@wannaphong
Copy link
Member

After python-crfsuite fixed python 3.10 problem but they doesn't release new version to PyPI. scrapinghub/python-crfsuite#139
I think we should change all python-crfsuite models to Pytorch models.
@wannaphong
Copy link
Member Author

wannaphong commented Feb 22, 2022 •
edited

List python-crfsuite models:

  • Thai NER (Done)
  • crfcut
  • crfcls

@wannaphong wannaphong added this to the 3.1 milestone Feb 22, 2022
@wannaphong wannaphong self-assigned this Feb 22, 2022
@wannaphong wannaphong added this to To do in PyThaiNLP Feb 22, 2022
@wannaphong
Copy link
Member Author

If it want to deep learning models, it should working with onnx.

@wannaphong wannaphong modified the milestones: 3.1, Future Aug 19, 2022
@wannaphong
Copy link
Member Author

Move to the future

@bact bact mentioned this issue Oct 11, 2022
Open
@bact bact added refactoring a technical improvement which does not add any new features or change existing features. Hacktoberfest for Hacktoberfest event labels Oct 11, 2022
@wannaphong wannaphong moved this from To do to In progress in PyThaiNLP Feb 1, 2023
@wannaphong wannaphong modified the milestones: Future, 4.0 Feb 1, 2023
@wannaphong wannaphong modified the milestones: 4.0, Future Apr 14, 2023
@wannaphong
Copy link
Member Author

5e97e7c Change the default NER to thainer-v2 that don't use python-crfsuite.

@wannaphong wannaphong mentioned this issue Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wannaphong wannaphong

Labels
Hacktoberfest for Hacktoberfest event refactoring a technical improvement which does not add any new features or change existing features.
Projects
PyThaiNLP
  
In progress
Milestone
Future
Development

No branches or pull requests
2 participants
@bact @wannaphong