Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands /pay2extend & /pay2skip to the transactions app #1290

Open
jirislav opened this issue Oct 14, 2023 · 6 comments
Open

Add commands /pay2extend & /pay2skip to the transactions app #1290

jirislav opened this issue Oct 14, 2023 · 6 comments

Comments

@jirislav
Copy link

jirislav commented Oct 14, 2023

Hi,

per request of the famous H1.tmen fixor, I'd like to request to add two commands, that will enable any user to buy a track extension or skip using a configured amount of planets.

Proposed commands:

  • /pay2extend
  • /pay2skip

For example, on TM2, server LOLMAPS, there is a message that you can pay 200 planets for first extension & 400 for the second one. If you wish to skip, you pay 10000 planets. The only problem is that it's not automated and a present admin is required.

I thought that it could be nice to have it actually added to the core pyplanet, since many servers could benefit from this.

I'm attaching fully tested and working PR: #1289

Here are some in-game screenshots for you to get better idea of this feature:

image

image

image

image

@Tavris1
Copy link

Tavris1 commented Oct 15, 2023

Since pyplanet version 0.11 there is a /prev command.
It would be great if you include it (/pay2prev?).

@jirislav
Copy link
Author

jirislav commented Oct 15, 2023

Since pyplanet version 0.11 there is a /prev command.
It would be great if you include it (/pay2prev?).

Sure, I can do that. But I don't like the command name /pay2prev since it should be a verb instead of a noun. I'm brainstorming right now, but how about /pay2rewind?

On the other hand, if we used nouns instead, we could write /pay4..., which was my first version, but I didn't like that extension is much longer that just extend.

What are your thoughts on this, @tomvlk ?

@jirislav
Copy link
Author

jirislav commented Nov 2, 2023

It has been a while, could someone else with enough permissions review this change, merge it and release it? 🙏🏿

Maybe @TheMaximum ? 🥺

@tomvlk tomvlk self-assigned this Nov 3, 2023
@jirislav
Copy link
Author

@tomvlk It is nearly two months since the proposal. It is already widely tested by Santa & Fixor (from LOLmaps on TM2) and I am ready to work through your review. Would you please review the changes?

@jirislav
Copy link
Author

jirislav commented Mar 8, 2024

@tomvlk any progress regarding this pull request? It has been almost half a year. Admins on TM2 LOLMAPS (server with the most players long-term) would love to see this merged.

@tomvlk
Copy link
Member

tomvlk commented Mar 21, 2024

Soon ™️ @jirislav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants