Two score tables are shown in some SM Modes

[skybaks]

When using pyplanet with some shootmania modes like Elite/ElitePro.Script.txt you see two score tables.

Invoking "Maniaplanet.UI.SetScoresTableVisibility" with player "login" and "false" from instance.gbx() hides the second scoretable and leaves only the custom manialink score table.

I see some code in the BaseUIManager to invoke "Maniaplanet.UI.SetAltScoresTableVisibility" conditionally when the game is shootmania. I'm wondering what the background for implementing that was and whether it might make sense to also invoke SetScoresTableVisibility at the same time as SetAltScoresTableVisiblity.

The thing is, for Elite at least, you would always want the SetScoresTableVisibility=false.

Expected Behavior

In elite the scoretable is implemented in custom manialink. I would expect that only that score table is shown.

Actual Behavior

Both the custom scoretable and the game's built-in score table are shown.

Steps to Reproduce (including precondition)

1. Start a server with mode Elite/ElitePro.Script.txt
2. Join server
3. Start pyplanet
4. Press tab to open scoretable and observe two are displayed on top of eachother.

Your Environment

• OS: Windows
• PyPlanet version: 0.10.0-rc1
• Python version: 3.7.0

[w1lla]

It seems to be that during the start of PyPlanet it Resets all UI.Properties hence (Shootmania.UI.ResetProperties) and then tries to set the AltScoresVisibility to True.

However the AltScoresVisibility is for the ALT Key.

See:

https://github.com/maniaplanet/script-xmlrpc/blob/master/XmlRpcListing.md#maniaplanetuisetaltscorestablevisibility

[w1lla]

Found the culprit i guess:

PyPlanet/pyplanet/core/ui/ui_properties.py

Line 55 in a0f07f6

async def on_start(self):

It resets the UIProperties so in any case the ScoresTable will be both shown,

[tomvlk]

Reset is needed in order to have a ground truth in both the controller and the dedicated, after resetting we are setting the defaults, aren’t we?

[w1lla]

Yes that is correct it goes back to default, but after a map restart or a next map the apparent bug seems to be solved. Not sure