1.x: Remove pool support, add env-variable configuration, upgrade peewee, uvloop #1152
Conversation
|
|
||
| # Owner, will be granted highest level of admin at initial start and connect. | ||
| PYPLANET_OWNER = None |
There was a problem hiding this comment.
Does this mean that there can only be one owner?
For the Smurfs we currently have two owners: Haagse and me...
There was a problem hiding this comment.
The owner is just there to grant the initial admin rights to, then this person can give the rights to the other players in-game. @TheMaximum
| # FIX for #331. Replace utf8 by utf8mb4 in the mysql driver encoding. | ||
| if conf['ENGINE'] == 'peewee_async.MySQLDatabase' and 'charset' in db_options and db_options['charset'] == 'utf8': | ||
| logging.info('Forcing to use \'utf8mb4\' instead of \'utf8\' for the MySQL charset option! (Fix #331).') | ||
| db_options['charset'] = 'utf8mb4' |
There was a problem hiding this comment.
The charset no longer needs to be forced?
There was a problem hiding this comment.
I set the default to be this. This used to be misconfigured default on very old servers.
pyplanet/utils/log.py
Outdated
| @@ -30,7 +30,7 @@ def get_client(cls): | |||
| if not cls.CLIENT: | |||
| cls.CLIENT = Client( | |||
| dsn='https://bcbafd2d81234d53b32c66077ae0a008:[email protected]/2', | |||
There was a problem hiding this comment.
Is Sentry running again? Otherwise we might as well remove it.
There was a problem hiding this comment.
It's not for now, do you think it's worth it to start it again? I will upgrade it, clean it and start it if you think so.
…s for upgrading peewee
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Basic Auth String | a4d688d | pyplanet/utils/log.py | View secret |
| 2880307 | Basic Auth String | b3a1d48 | pyplanet/utils/log.py | View secret |
| 2880307 | Basic Auth String | b3a1d48 | pyplanet/utils/log.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
tomvlk
changed the title
tomvlk
changed the title
tomvlk
changed the title
Doesn't reflect in documentation yet!
Fixes #1094
Fixes #1093
Fixes #1153
Fixes #1154
Minimum Python Version: 3.10!