-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-local impl
definition, they should be avoided as they go against expectation
#4094
Labels
Comments
Please update to the current version 0.21.2 which resolves this. |
@adamreichold Thanks for your information! In GreptimeDB we can't upgrade pyo3 now due to our deps (arrow, datafusion) are using pyo3 0.20:
But once these deps upgrade, we'll try this out. Cross ref - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
In our code https://github.com/GreptimeTeam/greptimedb/blob/main/src/script/src/python/pyo3/vector_impl.rs#L94 like
Compile with toolchain
nightly-2024-04-18
would get the following error:Steps to Reproduce
git clone https://github.com/waynexia/greptimedb.git cd greptimedb git checkout update-toolchain-3 make clippy
Source
Backtrace
Your operating system and version
Arch Linux x86_64 6.8.6-arch1-1
Your Python version (
python --version
)Python 3.11.8
Your Rust version (
rustc --version
)rustc 1.79.0-nightly (becebb315 2024-04-17)
Your PyO3 version
0.20
How did you install python? Did you use a virtualenv?
pacman
Additional Info
To workaround it, add this to
Cargo.toml
The text was updated successfully, but these errors were encountered: