-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build meta wheel does not respect metadata_directory
per PEP-517
#1973
Comments
Is changing the metadata outside of the build backend allowed in PEP 517? My read was that the build backend controls the metadata. The prepare call is meant for resolver who want to get dependency information but don't actually want to perform the (potentially expensive) compilation (we may not select this version due to conflicts in the deps we get). The cited region in the spec means that you can take this shortcut and have the guarantee that you can build a wheel for installation that has the deps that were used in the resolution. What's your use case for changing the metadata outside of maturin? |
We have a monorepo at work. So use use If it simplifies the mental model, the same thing could be accomplished by us publishing the module as a package, setting We'll probably also reuse this package to add the "private" classifier automatically. |
Bug Description
(similar to pypa/setuptools#1825)
From https://www.python.org/dev/peps/pep-0517/#build-wheel:
Maturin ignores the
metadata_directory
argument inbuild_wheel
which makes it hard to "wrap" build backends and adjust metadata. (The workaround is to wrapbuild_wheel
as well, and unpack-adjust-rechecksum-repack the wheel)maturin/maturin/__init__.py
Line 57 in 14a7b2d
Your maturin version (
maturin --version
)main
Your Python version (
python -V
)(unrelated)
Your pip version (
pip -V
)(unrelated)
What bindings you're using
None
Does
cargo build
work?If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash
/
)?Steps to Reproduce
pyproject.toml
with an "in-repo" `build-backendbuild_hooks.py
):(Set up a normal maturin project otherwise)
Build the wheel:
python -m pip wheel .
The text was updated successfully, but these errors were encountered: