Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do I need to hardcode my own GPG keys for new UserGPGKey class? #2957

Open
austinlucaslake opened this issue Apr 24, 2024 · 2 comments
Open

Comments

@austinlucaslake
Copy link

austinlucaslake commented Apr 24, 2024

Background

I'm developing a UserGPGKey class to expose this library to GitHub's REST API endpoints for GPG keys. The UserGPG class is moduled similar to the already-existing UserKey class. The necessiary modifcations have been made to NamedUser and AuthenticatedUser in order to access GPG keys after authentication.

Problem

In the tests of UserKey, AuthenticatedUser, and NamedUser tests, there is information provived on some SSH keys which from my understanding comes from @jacquev6. Here are screenshots from the codebase showcasing what I am refering to:

tests/UserKey.py
image

tests/AuthenticatedUser.py
image

tests/NamedUser.py
image

What I'd like to know is if I'd need something similar and hardcode information from my own GPG key(s) into the testing code for UserGPGKey?

If possible, I'd like to avoid doing this for privacy reasons.
Thanks in advance for reading this rather lengthy issue! 😅

@austinlucaslake
Copy link
Author

Working towards #2413

@austinlucaslake
Copy link
Author

austinlucaslake commented Apr 24, 2024

For clarity, the fork can be found here, and the relevant commits/changes here.

@austinlucaslake austinlucaslake changed the title Need GPG key id for UserGPGKey class Hardcoded KNeed GPG key id for UserGPGKey class Apr 28, 2024
@austinlucaslake austinlucaslake changed the title Hardcoded KNeed GPG key id for UserGPGKey class Hardcoded keys in codebase. Do I need to hardcode my own GPGs for new U Apr 28, 2024
@austinlucaslake austinlucaslake changed the title Hardcoded keys in codebase. Do I need to hardcode my own GPGs for new U Hardcoded ssh keys in codebase. Do I need to hardcode my own GPGs for new UserGPGKey class? Apr 28, 2024
@austinlucaslake austinlucaslake changed the title Hardcoded ssh keys in codebase. Do I need to hardcode my own GPGs for new UserGPGKey class? Hardcoded ssh keys in codebase. Do I need to hardcode my own GPG keys for new UserGPGKey class? Apr 28, 2024
@austinlucaslake austinlucaslake changed the title Hardcoded ssh keys in codebase. Do I need to hardcode my own GPG keys for new UserGPGKey class? Do I need to hardcode my own GPG keys for new UserGPGKey class? Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant