Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow.create_dispatch(): Arguments support "ref: Commit" but API does not #2881

Open
jonapich opened this issue Jan 22, 2024 · 2 comments
Open

Workflow.create_dispatch(): Arguments support "ref: Commit" but API does not #2881

jonapich opened this issue Jan 22, 2024 · 2 comments

Comments

@jonapich
Copy link

This:

PyGithub/github/Workflow.py

Line 137 in 34c4642

ref = ref.sha

The Github API simply doesn't support SHAs there: it's limited to branches and tags.

The REST API documentation also mentions branches and tags: https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event--parameters
@EnricoMi
Copy link
Collaborator

You are right. Would you like to create a PR to fix this?

laysauchoa added a commit to laysauchoa/PyGithub that referenced this issue Mar 27, 2024
@laysauchoa
remove commit reference
17873d5 
The Github API doesn't support commit SHAs
as it is limited to branches and tags.

closes:PyGithub#2881
@laysauchoa laysauchoa mentioned this issue Mar 27, 2024
Open
@laysauchoa
Copy link

Hi @EnricoMi would that fix it? #2931 Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonapich @laysauchoa @EnricoMi