Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format replacement species field #161

Open
emillipede opened this issue Aug 6, 2019 · 9 comments
Open

format replacement species field #161

emillipede opened this issue Aug 6, 2019 · 9 comments
Labels
data update enhancement New feature or request help wanted Extra attention is needed

Comments

@emillipede
Copy link
Collaborator

emillipede commented Aug 6, 2019

right now, the entire replacement species field in the "tree" view of the sidebar is italicized. the "vacant site" view has no italics. the only italics that should appear in these views are for the tree species names. other parts of the field should appear in regular text.

for example, the text in the replacement species field should appear as:

"Brahea armata, Pinus torreyana (east side only)" instead of
"Brahea armata, Pinus torreyana (east side only)"

I think this update will involve some data processing. I don't know how to start to address it. If you have ideas, please share.

Screen Shot 2019-08-05 at 9 49 13 PM

@emillipede emillipede added this to open issues in santa monica tree map via automation Aug 6, 2019
@wgnvrd
Copy link
Contributor

wgnvrd commented Aug 6, 2019

if anyone else isn't working on this, i would like to.

@emillipede
Copy link
Collaborator Author

thank you @isabelle-wagenvoord! sorry I missed your comment. no one's started work on this issue, you're more than welcome to go for it. the species attributes csv in the pipeline repository includes the species names.

there's a related partial PR that explores how to add common/english names to the listed replacement species. I think @ian-r-rose has some thoughts about how to approach that problem, and as part of the solution, he recommended the work documented in issue #36

@wgnvrd
Copy link
Contributor

wgnvrd commented Aug 7, 2019

alright, thank you @emillipede !

@emillipede emillipede moved this from open issues to in progress in santa monica tree map Aug 13, 2019
@emillipede
Copy link
Collaborator Author

emillipede commented Aug 13, 2019

examples of oddities in the "replacement species" field:

https://public-tree-map.surge.sh/?id=10941912
"Replacement species will be designated as a part of a future streetscape for the Expo Line"

https://public-tree-map.surge.sh/?id=10942416
"Waiting on CALTRANS to release this street to the City of SM"

https://public-tree-map.surge.sh/?id=10924429
"E/S of St. = Pinus torreyana, W/S of St. = Platanus racemosa"

@isabelle-wagenvoord

@wgnvrd
Copy link
Contributor

wgnvrd commented Aug 13, 2019

Hi @emillipede,
thank you for the examples!
how would i look up if a particular tree species exist in the json without fetching the whole thing?

@emillipede
Copy link
Collaborator Author

hi @isabelle-wagenvoord glad you made it home ok!

one option is to look in the species attributes csv that's in the data pipeline repository.

right now, there's no species json, but @ian-r-rose and I did talk about adding something like it

@wgnvrd
Copy link
Contributor

wgnvrd commented Aug 14, 2019

thanks @emillipede!
sorry, i'm not really familiar with how to go about this. should i just parse the csv file from within the javascript code when the map first loads? if so, should i use a library like d3 or papaparse to do it for me or research how to do it myself?

@emillipede
Copy link
Collaborator Author

hi @isabelle-wagenvoord I'm sorry for the confusion, I'm not sure quite how to approach the problem.

it seems like it may be faster to preprocess species name data, either as part of the existing json or in a companion json, rather than to parse it when a users loads the map. if some of this processing is done in the pipeline, then there could be some javascript code that recognizes species names (that are already indicated in one way or another) and adds specific formatting to text with species names.

to include the next 5 years' worth of planting schedules, a lot of the data pipeline parsing needs updates. for now, I think makes sense to check in with @ian-r-rose about options for improving how species names are identified in the data pipeline (they could be included in those other updates). does that sound to you like an ok approach?

@wgnvrd
Copy link
Contributor

wgnvrd commented Aug 16, 2019

hi @emillipede
yes, that sounds fine. it seems like this issue is a bit out of reach for me for now. thanks!

@emillipede emillipede moved this from in progress to data update in santa monica tree map Aug 20, 2019
@emillipede emillipede added help wanted Extra attention is needed improvement labels Apr 23, 2020
@emillipede emillipede moved this from data update to open issues in santa monica tree map Apr 23, 2020
@emillipede emillipede added enhancement New feature or request and removed improvement labels Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data update enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants