Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreblankinputs is not supported #1470

Closed
1 task done
scottjasso opened this issue Feb 23, 2023 · 3 comments · Fixed by #1551 · May be fixed by #1479
Closed
1 task done

ignoreblankinputs is not supported #1470

scottjasso opened this issue Feb 23, 2023 · 3 comments · Fixed by #1551 · May be fixed by #1479
Labels
Area: Indexer Issue is related to indexers. Status: In Progress In Progress Type: Enhancement Current situation is suboptimal and could use improvement. Type: Feature Request Issue is a feature request.

Comments

@scottjasso
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

In my custom cardigann yaml, the ignoreblankinputs field does not have any effect.

I have things like

  inputs:
    imdbId: "{{ .Query.IMDBIDShort }}"

And whether ignoreblankinputs is true or false, that input is included in the query params, which breaks the query.

Instead, I have to use a very long, convoluted "$raw" query with conditionals ( {{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}... repeat for each input).

Expected Behavior

ignoreblankinputs: true should mean that blank inputs are not included in the query params.

Steps To Reproduce

No response

Environment

- OS: ubuntu server 20.04
- Prowlarr: 1.1.3.2521
- Docker Install: Yes
- Using Reverse Proxy: Yes
- Browser: N/A

What branch are you running?

Develop

Trace Logs?

Not including.

@scottjasso scottjasso added Status: Needs Triage New Issue needing triage Type: Bug Issue is a bug labels Feb 23, 2023
@scottjasso
Copy link
Contributor Author

I didn't include any logs since the issue is obvious from the code. Looks like this PR started to add support for it: https://github.com/Prowlarr/Prowlarr/pull/644/files
but it was never merged.

@bakerboy448
Copy link
Contributor

bakerboy448 commented Feb 23, 2023

ignoreblankinputs was never added and the wiki page erroneously indicated it did; that has been fixed.

ignoreblankinputs is not supported by jackett and is not part of any valid Cardigann schema at this time.

for examples of how to workaround these; see any of the UNIT3D YML definitions

@bakerboy448 bakerboy448 added Type: Feature Request Issue is a feature request. Area: Indexer Issue is related to indexers. and removed Type: Bug Issue is a bug labels Feb 23, 2023
@scottjasso
Copy link
Contributor Author

Thanks! I'm using the $raw conditional queries for now, and that works. Thank you for updating the wiki so quickly.
Definitely a quality-of-life feature request then. 👍

@mynameisbogdan mynameisbogdan added Status: In Progress In Progress Type: Enhancement Current situation is suboptimal and could use improvement. and removed Status: Needs Triage New Issue needing triage labels Feb 26, 2023
@mynameisbogdan mynameisbogdan linked a pull request Feb 27, 2023 that will close this issue
2 tasks
@mynameisbogdan mynameisbogdan linked a pull request Mar 22, 2023 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Indexer Issue is related to indexers. Status: In Progress In Progress Type: Enhancement Current situation is suboptimal and could use improvement. Type: Feature Request Issue is a feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants