Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Angular 8 support #333

Open
mtinnes opened this issue May 29, 2019 · 4 comments
Open

Angular 8 support #333

mtinnes opened this issue May 29, 2019 · 4 comments

Comments

@mtinnes
Copy link

mtinnes commented May 29, 2019

Bug, feature request, or proposal:

Refactor any references to DOCUMENT in order to comply with Angular 8 changes

What is the expected behavior?

md2 should compile without error when targeting Angular 8

What is the current behavior?

ERROR in ./node_modules/md2/core/common-behaviors/common-module.js 64:46-54
"export 'DOCUMENT' was not found in '@angular/platform-browser'

What are the steps to reproduce?

Compile an app targeting Angular 8 using md2 components

What is the use-case or motivation for changing an existing behavior?

Compatibility with Angular 8

Which versions of Angular, MD2, OS, browsers are affected?

Angular 8, MD2 0.33

Is there anything else we should know?

DOCUMENT is removed from @angular/platform-browser If you use DOCUMENT from @angular/platform-browser, you should start to import this from @angular/common.

@thevirajshelke
Copy link

Facing the same issue when using angular v8

ERROR in ./node_modules/md2/core/common-behaviors/common-module.js 64:46-54
"export 'DOCUMENT' was not found in '@angular/platform-browser'

@haskelcurry
Copy link

Same thing. Looking for alternative lib

@ravishah94
Copy link

ravishah94 commented Jul 10, 2019

I want to resolve this issue via PR #335. The PR contains changes with the import of DOCUMENT from tyhr @angular/common instead of @angular/platform-browser to support MD@ with Angular 8 version.

@shane-chen
Copy link

Have a look at angular-md2, which migrate md2 to angular8.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants