Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Latest commit

 

History

History
15 lines (13 loc) · 735 Bytes

CODE_REVIEWS.md

File metadata and controls

15 lines (13 loc) · 735 Bytes

Code reviews for MD2

  • Before any coding begins on new, large, or breaking work, a design discussion should take place.
  • All code changes require a review and approval.
  • Authors should attempt to keep PRs to 200 - 300 line changes.

Workflow

  1. The code author sends a PR for review. This request should include:
  • A mention of the intended reviewer(s) (e.g., @dharmeshpipariya)
  • A high-level description of the change being made.
  • Links to any relevant issues.
  • Screenshots (for visual changes or new additions)
  1. Reviews provide comments and the author responds / makes changes. Repeat until LGTM.
  2. One or more of the reviewers applies the "LGTM" label.
  3. The party responsible for merging PRs will do so.