Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to run the online test without having the mojang server ban us #372

Open
rom1504 opened this issue Feb 20, 2016 · 10 comments
Open
Labels

Comments

@rom1504
Copy link
Member

rom1504 commented Feb 20, 2016

6fb6b35

saving the tokens somehow might do it

@rom1504 rom1504 added the test label Feb 20, 2016
@rom1504
Copy link
Member Author

rom1504 commented Feb 20, 2016

I recently switched to my own second account instead of @roblabla 's for the test and I just got that mail from mojang:

We suspect that your Mojang account email and password may have been compromised. To prevent unauthorized use of your account we've reset your account password. If you use that same password on other sites we strongly recommend that you change your password on those sites as well.

I guess that's what happened with roblabla's account too.

The online test is disabled for now, but we really need to find a better solution if we want to enable that online mode test.

@roblabla
Copy link
Member

We could implement our own auth server fairly easily, and run the tests against that. Not as high fidelity as using the real minecraft servers, but should work well enough ^^.

@pqml
Copy link

pqml commented Apr 24, 2016

I've made a mini module to deal with tokens and simulate the way the official launcher works
I don't know if it could fix the problem ?

https://github.com/pqml/prismarine-tokens

@rom1504
Copy link
Member Author

rom1504 commented Jan 30, 2017

@rom1504
Copy link
Member Author

rom1504 commented Jul 13, 2017

some discussion about this, there PrismarineJS/mineflayer#551

@rom1504
Copy link
Member Author

rom1504 commented Jul 20, 2017

similar to prismarine token is https://github.com/PrismarineJS/node-minecraft-wrap/blob/master/lib/wrap_client.js#L37

Problem is we run tests in parallel + circle ci doesn't keep the token file between runs.

Can we make circle ci keep the token file ? (let's say launcher_profiles.json)

That might be a good enough solution.

@pqml
Copy link

pqml commented Jul 20, 2017

I don't think Circle CI can have persistent data.

A solution could be to store the json data to a remote server via a simple REST API and secure calls with an API Key. (Firebase / AWS services are good but a simple php script will work too)

You can setup environment variables in Circle CI to hide that key (https://circleci.com/docs/1.0/environment-variables/#setting-environment-variables-for-all-commands-without-adding-them-to-git)

@rom1504
Copy link
Member Author

rom1504 commented Jul 21, 2017

ah yes, "hidden" key + encrypted launcher_profiles.json in an other repo.
couldn't be enabled for pull requests, but otherwise it might work

@Saiv46
Copy link

Saiv46 commented May 12, 2024

There's alternative (and open-source) authentication server available to everyone - Ely.by!

I think we can run instance of https://github.com/elyby/accounts alongside in CI

@rom1504
Copy link
Member Author

rom1504 commented May 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants