Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game log isn't encoded with UTF-8 #2419

Open
1 task done
StrangeOne101 opened this issue May 19, 2024 · 3 comments
Open
1 task done

Game log isn't encoded with UTF-8 #2419

StrangeOne101 opened this issue May 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@StrangeOne101
Copy link

StrangeOne101 commented May 19, 2024

Operating System

Windows 10

Version of Prism Launcher

8.3

Version of Qt

6.6.3

Description of bug

When non english characters (in this case, Russian) characters appear in the log (the log within Prism), they appear encoded incorrectly.

This is copied and pasted from the log

[14:52:54] [Render thread/INFO]: [CHAT] игрока, пригла�ившего Ва� на �ервер.
[14:52:54] [Render thread/INFO]: [CHAT] 
[14:52:54] [Render thread/INFO]: [CHAT] �аграда: ᴇ�ᴇʀᴀʟᴅ на 3 дн� (Вам и Пригла�ившему)
[14:52:54] [Render thread/INFO]: [CHAT] Е�ли у Ва� уже е�ть ᴇ�ᴇʀᴀʟᴅ, тогда

Steps to reproduce

  1. Copy and paste something in russian in chat
  2. Open Prism log
  3. See how the chat message appears incorrectly

Suspected cause

I suspect the log isn't using UTF-8 like it should be.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@StrangeOne101 StrangeOne101 added the bug Something isn't working label May 19, 2024
@Trial97
Copy link
Member

Trial97 commented May 19, 2024

This may be due to how your locale is set up, as this works as intended for me on linux.
Make sure your windows locale is set correctly(no I have no idea how to do stuff on windows so search for it on google).

@StrangeOne101
Copy link
Author

I've looked it up, and it says the locale for Windows is only used when the application doesn't support unicode. This makes me think that there is some program field somewhere that says whether the program supports it or not.

My current locale was set to English US, which is fine. The locales available are only regional locales (every language with variants for location).
image

@Trial97
Copy link
Member

Trial97 commented May 19, 2024

Prism uses that locale to decode the std output of Minecraft: https://github.com/PrismLauncher/PrismLauncher/blob/develop/launcher/LoggedProcess.h#L84
try adding Russian or something there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants