add stream_logs
parameter to trigger_sync
#28
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes exposes a
stream_logs
parameter to thetrigger_sync
task to surface airbyte sync logs through the Prefect logger and adds associated tests / fixtures.This required refactoring
AirbyteClient.get_job_status
to conditionally return logs ifstream_output
is True.This PR also switches from the standard python logger to the logger fetched by
get_run_logger()
, which required a change to all associated unit tests that previously called theTask.fn()
method.Relevant Issue(s)
addresses #19
Checklist