-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zlib fails to link with Whole Program Optimization enabled #2183
Comments
You're not doing anything wrong - we just started seeing this on our CI as well - thanks for opening an issue! Since ZLib and OpenSSH are built with optimizations, Visual Studio requires that both are built with the same compiler version (major and minor, per https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/fatal-error-c1047?view=msvc-170). PowerShell/ZLib was compiled with version 17.7. Other temporary workarounds besides what you already mentioned:
We are working on a more permanent solution. |
Prerequisites
Steps to reproduce
There's a strong possibility that I'm doing something wrong here with my VS setup. That said, I believe I've faithfully followed the instructions here: https://github.com/PowerShell/Win32-OpenSSH/wiki/Building-OpenSSH-for-Windows-(using-LibreSSL-crypto).
Relevant versions:
Microsoft Visual Studio Enterprise 2022
Version 17.8.0
VisualStudio.17.Release/17.8.0+34309.116
Microsoft .NET Framework
Version 4.8.09032
Visual C++ 2022 00482-20704-71775-AA324
Microsoft Visual C++ 2022
Despite zlib and OpenSSH both referencing PlatformToolset v143, I get a link error with Whole Program Optimization enabled:
The error goes away if I disable this setting.
Expected behavior
It builds
Actual behavior
Error details
No response
Environment data
n/a
Version
9.4.0.0-p1
Visuals
No response
The text was updated successfully, but these errors were encountered: