Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgrest-release command offers unnecessary options on a rel- branch #3082

Closed
steve-chavez opened this issue Dec 2, 2023 · 0 comments
Closed

postgrest-release command offers unnecessary options on a rel- branch #3082

steve-chavez opened this issue Dec 2, 2023 · 0 comments
Labels
minor nix related to Nix tooling

Comments

@steve-chavez
Copy link
Member

Problem

Now that we're switching to a release branches model. When creating and switching to a rel-X.Y branch:

$ git checkout -b rel-12.0

There are some unnecessary options:

$ postgrest-release
Current version is 11.2.0
1) 11.2.0.20231201
2) 11.3.0.20231201
3) 11.2.1
4) 11.3.0
5) 12.0.0
Please select the new version: 5
Selected 12.0.0
Updating postgrest.cabal ...
Committing ...
Updating CHANGELOG.md ...
Tagging ...
To push both the branch and the new tag, the following will be run:

git push --atomic upstream rel-12.0 v12.0.0

Solution

Only offer:

1) 12.0.0
2) 12.0.Z

Z should be suggested according to the existing patch versions.
@steve-chavez steve-chavez added minor nix related to Nix tooling labels Dec 2, 2023
@steve-chavez steve-chavez changed the title postgrest-release offers unnecessary options on a rel- branch postgrest-release command offers unnecessary options on a rel- branch Dec 2, 2023
This was referenced Dec 13, 2023
Closed
Open
wolfgangwalther added a commit to wolfgangwalther/postgrest that referenced this issue May 9, 2024
@wolfgangwalther
nix: Adjust postgrest-release to new release workflow
59a37b9 
This changes the postgrest-release tool to work with our new workflow.
It can be run on main and the v* release branches. When on a release
branch, it will bump a patch version and push to that branch only.

When on main, it will bump a minor version by default. To bump a major
version, pass --major. This first bump will be force-pushed to the
v<major> branch. A second bump to the current development version will
then be pushed to the main branch.

The tool will not tag commits anymore - this happens in CI
automatically.

References PostgREST#3113
Resolves PostgREST#3082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor nix related to Nix tooling
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nix: remove pre-release in favor of nightly releases laurenceisla/postgrest
1 participant
@steve-chavez