-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popmotion: bounce animation with some durations / velocity updates to NaN #910
Comments
Seems to happen when dampingRatio becomes
Where the damping is 0 and the stiffness is 0.
And it seems 0 values can come from
|
Can I help clarify this issue or help to patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When starting a bounce animation with some configurations of
duration
andvelocity
can result inNaN
update values.(The animations do successfully end at their
to
values though.)For example:
https://codesandbox.io/s/popmotion-velocity-nan-et3t3?file=/src/index.tsx:0-425
This animation should not have
NaN
valuesonUpdate
It seems that the actual Nan is created hereabouts:
popmotion/packages/popmotion/src/animations/generators/spring.ts
Line 75 in a1903c8
as a result of an invalid dampingRatio.
Please let me know how I could help with this issue. Thank you.
This issue was initially discovered here
framer/motion#1094
The text was updated successfully, but these errors were encountered: