-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_attachDom type signature is too restrictive #5665
Labels
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
_attachDom
's docs say that it can be overriden to support any type of node that is not just only a shadow root. The return types though seem to beShadowRoot | null
which means that you cannot returnthis
as an acceptable root.polymer/lib/mixins/element-mixin.js
Line 734 in 76c71e1
polymer/lib/mixins/element-mixin.d.ts
Line 221 in 36fb37e
Steps to Reproduce
Expected Results
no compilation error
Actual Results
compilation error
Browsers Affected
N/A
Versions
The text was updated successfully, but these errors were encountered: