-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CorrespondenceEstimation] There may be something wrong with the annotation #6043
Comments
Yeah, that might be a bit confusing. |
Then I think modifying this comment would make the meaning clearer. As you said, change it to "CorrespondenceEstimation represents the basic/simple class for determining correspondences between target and query point sets/features". And It would be best if there is also an explanation of the basic principles "For each point in the source point cloud, find the closest point in the target point cloud (usually using KD-tree or other acceleration structures).". |
https://github.com/PointCloudLibrary/pcl/blob/master/registration/include/pcl/registration/correspondence_estimation.h#L386
It says "CorrespondenceEstimation represents the base class for determining correspondences between target and query point sets/features.", but CorrespondenceEstimation does not have subclasses. Instead, it has a base class named CorrespondenceEstimationBase.
The text was updated successfully, but these errors were encountered: