Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CorrespondenceEstimation] There may be something wrong with the annotation #6043

Closed
QiuYilin opened this issue May 17, 2024 · 2 comments · Fixed by #6054
Closed

[CorrespondenceEstimation] There may be something wrong with the annotation #6043

QiuYilin opened this issue May 17, 2024 · 2 comments · Fixed by #6054

Comments

@QiuYilin
Copy link
Contributor

https://github.com/PointCloudLibrary/pcl/blob/master/registration/include/pcl/registration/correspondence_estimation.h#L386

It says "CorrespondenceEstimation represents the base class for determining correspondences between target and query point sets/features.", but CorrespondenceEstimation does not have subclasses. Instead, it has a base class named CorrespondenceEstimationBase.

@QiuYilin QiuYilin added the status: triage Labels incomplete label May 17, 2024
@mvieth
Copy link
Member

mvieth commented May 17, 2024

Yeah, that might be a bit confusing. CorrespondenceEstimationBase is abstract (so not usable by itself) and the base class/parent class of four non-abstract correspondence estimation methods, including CorrespondenceEstimation. CorrespondenceEstimation is probably the most "basic" or "simple" of the four correspondence estimation methods. See also the inheritance diagram at https://pointclouds.org/documentation/classpcl_1_1registration_1_1_correspondence_estimation_base.html

@QiuYilin
Copy link
Contributor Author

QiuYilin commented May 20, 2024

Then I think modifying this comment would make the meaning clearer. As you said, change it to "CorrespondenceEstimation represents the basic/simple class for determining correspondences between target and query point sets/features". And It would be best if there is also an explanation of the basic principles "For each point in the source point cloud, find the closest point in the target point cloud (usually using KD-tree or other acceleration structures).".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants