Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail captions ALWAYS display after 2.5.12 #342

Open
jradwan opened this issue Oct 11, 2022 · 2 comments
Open

Thumbnail captions ALWAYS display after 2.5.12 #342

jradwan opened this issue Oct 11, 2022 · 2 comments

Comments

@jradwan
Copy link

jradwan commented Oct 11, 2022

I just noticed that in v2.5.12, the image captions are appearing on the thumbnail page even though the "Show image caption" option is not checked. I was able to work around this for now by adding this to my config.inc.php (via local files editor):

$conf['show_thumbnail_caption'] = false;

It seems like even when the "Show image caption" option is NOT checked, it's still evaluating to true ({if $SHOW_THUMBNAIL_CAPTION}) in template/thumbnails.tpl.

@mozzenior
Copy link

mozzenior commented Nov 30, 2022

The cause seems to be that the code checks $smarty.cookies.view != 'list' to decide whether to add d-none to <div class="card-body">. This change was added in commit 3dbc47d.

Manually switching the view mode at least once would create the cookie.

FWIW, to recreate this issue, uncheck Show image caption then open the page in Incognito mode (assume the default view mode is grid mode).

@Apache84
Copy link

I think I have the same problem (v2.5.18).

$conf['show_thumbnail_caption'] = false;

Adding jradwan's code in themeconf.inc.php fixed the problem. Thank you for that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants