-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations #152
Comments
Good to open this issue to add it to the dashboard. Writing a note here to remind myself to check the old Dark Sky translations library to see if it'll work with my current basic text implementation, or if I need to have the full summary string working before I can leverage off that. |
While I don't know how you have the text implementation setup I think it should work with the translation library but if not you could always remove anything you're not using and add it back when you do the text summaries. I also didn't notice this until it was mentioned in the BriefSky issue but DarkSky did give an approximation on how they had their weather conditions setup https://github.com/Pirate-Weather/translations?tab=readme-ov-file#weather-conditions EDIT: No idea what the plans are for the translations repo but I created a PR to fix a bunch of issues related to dependencies and created a lint action as well. |
Describe the feature
This was something I posted in #48 but maybe something for the 2.0 version you could get the translations working and then down the line you could add in the text summaries?
You could make have something like this for English (not including things needed for the summaries):
English Translations
I'm aware that some of these strings aren't in the translation module but it might be good to define them in case they get used in the future? Even if you just have the summaries of the conditions for now it would be a good starting point.
Acknowledgements
The text was updated successfully, but these errors were encountered: