Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation : date format isn't correct #168

Open
tech62 opened this issue Nov 12, 2022 · 1 comment
Open

French translation : date format isn't correct #168

tech62 opened this issue Nov 12, 2022 · 1 comment

Comments

@tech62
Copy link
Contributor

tech62 commented Nov 12, 2022

Hi,

I've seen in different view/component, you're using YYYY/MM/DD format, but the french date format is DD/MM/YYYY, how can we fix that ?
I've change the en-CA to fr-FR and it's ok, but we can probably dealing something dynamicaly with localization ?

We can add a default localization value in DB for each user registered and an option in the profile or an update directly from the page when the user change is language ?

What are you thinking ?

{{ new Date(seasonData.start_date).toLocaleDateString("en-CA") }}

@tech62 tech62 changed the title French translation date format isn't correct French translation : date format isn't correct Nov 12, 2022
@PhlexPlexico
Copy link
Owner

If you'd like to make it more dynamic, PRs are always welcome! I'm pretty sure I just put that there in order to get a proper insert into the database. Pretty sure it stores it as a default date, but I used en-CA to ensure it could be inserted and incorrect formatting would be caught

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants