Discord bot!

[thboss]

80% completed, It just need to handle some exceptions
https://user-images.githubusercontent.com/40491968/110239013-d22c5300-7f55-11eb-9cdc-0479e09ef754.mp4

[kdev]

Nice work! Is the bot open-source? Found the repo.

[thboss]

The bot is based on csgo league bot https://github.com/csgo-league/csgo-league-bot
I will share the source code once it complete

[PhlexPlexico]

Wow that's awesome! By chance is it set to default 1v1s? Or is that configurable as well?

[PhlexPlexico]

AH! Yeah, that's because flags are required in order to properly submit to the database. Given that a flag is needed, you could maybe just make a default flag for wherever the region that the bot is hosted? I don't think it really matters, so you could just default it to CA (Canada), US, or GE even, and that should be fine.

G5API/routes/teams.js

Lines 358 to 381 in f139f8a

	newTeam = [
	{
	user_id: userID,
	name: teamName,
	flag: flag,
	logo: logoName,
	tag: tag,
	public_team: public_team,
	},
	];
	let sql =
	"INSERT INTO team (user_id, name, flag, logo, tag, public_team) VALUES ?";
	try {
	await db.withNewTransaction(newSingle, async () => {
	const insertTeam = await newSingle.query(sql, [
	newTeam.map((item) => [
	item.user_id,
	item.name,
	item.flag,
	item.logo,
	item.tag,
	item.public_team,
	]),

That's why, there is no "default" for a flag, so I would say maybe allow the user to set the team flag default?

[thboss]

I could add user flag to the users table https://github.com/thboss/CSGO-PUGs-Bot/blob/0729b920231c8e366bf55c781a450d4bb5ecd145/migrations/20200513_01_kPWNp-create-base-tables.py#L46
So when the user link their discord it's required to set their flag, and then the team flag is the captain's flag

[PhlexPlexico]

That would be perfect! I think I may swap out my bot that I'm using here for yours as well, but I also have a question - does this allow a user in discord to link their steam account with their discord? I am going to dig into your code here to check but that was the one thing I needed for PUGs was a users Steam ID and the only way I could really get around it was with a link system, like so stored in a SQLite database.

[thboss]

Of course, there is link system, https://github.com/thboss/CSGO-PUGs-Bot/blob/0729b920231c8e366bf55c781a450d4bb5ecd145/bot/cogs/commands.py#L157

So the user should enter a valid steam id/profile to link their discord account, and the bot built on postgreSQL as well

[PhlexPlexico]

I'll have to see about getting a postgresql server setup then so I can host my own instance, thanks for this!!

[PhlexPlexico]

Hey @thboss quick question in regards to setup. Is the G5API_URL= # URL where the web panel is hosted option set for the actual API endpoint, in this case https://phlex.avidgamers.me/api or just https://phlex.avidgamers.me?

Thanks!

[PhlexPlexico]

Also the min_player_ready issue, I think the call from the POST requires min_players_to_ready, notice the extra S in players, that should fix that bug.

[PhlexPlexico]

Ah, I found a bug in the plugin here. It looks like The plugin actually doesn't call that post if the match gets cancelled... I think that should indeed be changed in favour of letting the API know the match was cancelled.

[PhlexPlexico]

Okay, so I think I understand the problem that's going on. Right now, if a user calls the cancel match command from G5V, it calls an end match command on the server, then goes and updates the data before. Calling this will create an error on the game server stating that the match is already finalized. I remember running into this bug and now there's no easy way around it. I need to think of a way to wait for the game server to get a response before we forfeit or cancel a game on the /matches/cancel end point.

[PhlexPlexico]

get5_apistats.zip

Here's an update web stats. I've also updated the API to not throw error on finalized matches when calling finish, but report that we have finished with a 200 and return.

[PhlexPlexico]

There! I believe that should work as intended now, thanks for pointing that out! :)

[thboss]

Great! the match now is canceling when not all players ready up in time.

[thboss]

And yeah min_players_to_ready works fine, the reason to set this value is we can pick up 1v1, 2v2... games through the bot (not only 5v5)

[PhlexPlexico]

Perfect, glad to see everything seems to be operational then! I'm going to try and setup my own instance here and have a community try it out. Would you mind cleaning up the excess teams that you have right now? If not, I can remove all the test cases if you'd like!

Thanks!

[thboss]

Ah of course! I forgot to remove them, sorry for that.

[PhlexPlexico]

No worries at all, thanks! 👍

[thboss]

I have a question, is that possible to add rank to the leaderboard?
That would be useful to implement auto balance for teams in the bot

[PhlexPlexico]

There, it's in there now as totalMaps :)

[thboss]

I don't see totalMaps here https://phlex.avidgamers.me/api/leaderboard/players/pug
Does your web up to date?
However, I added auto balance teams based on average_rating
https://github.com/thboss/CSGO-PUGs-Bot

[PhlexPlexico]

It should be up now! It's total_maps

[thboss]

Sounds like it works well for all players /api/leaderboard/players but for pugs /api/leaderboard/players/pug there are incorrect values, there are players have wins: 2 and total_maps: 1

[PhlexPlexico]

Because wins is still counting as a global value both in and out of pugs... I could adjust it here as well!

E: It's now updated :)

[thboss]

I just added players stats commands :)

[kdev]

@thboss Good Job on that Discord Bot! Unfortunatly it is not possible to create any issues whatsoever to share some ideas or even raise an issue/bug?!

e.g. I would really like to see a Docker Image to easily deploy the Discord Bot to a personal host

[thboss]

Bot released here https://github.com/thboss/g5-discord-bot

[admrl]

Hi Everyone, is there a possibility that we create Discord roles and make them VIP perks just like in FACEIT? for example instances:

If player bought our VIP, they have perks like: Always Priority to be captain

but the question is what if all 10 players with VIP joined the queue, how do we randomize the VIP pick?

[PhlexPlexico]

If you're making feature requests, I would recommend creating an issue in the proper repository :)