-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMCSDCard.cpp fails to compile for esp32-c3 #171
Comments
paulftw
changed the title
SDCard.cpp fails to compile for esp32-c3
MMCSDCard.cpp fails to compile for esp32-c3
Jun 18, 2022
Hello @paulftw I'm no longer actively using Smooth (my project is completed) so I'm not actively keeping up with the development of the ESP32/IDF at this point. I do however accept pull requests to address issues. As such, feel free to propose a proper solution to the issue at hand and we'll discuss it. |
paulftw
added a commit
to paulftw/Smooth
that referenced
this issue
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a ESP32-C3 module.
After setting this chip as a target:
I'm running into a compilation error:
The culprit appears to be
SOC_SDMMC_HOST_SUPPORTED
- this symbol is not defined in the C3 soc_caps.h.As a result
sdmmc_host.h
does nothing and breaksMMCSDCard.cpp
.Workaround
Adding
to the top of the
smooth/lib/smooth/include/smooth/core/filesystem/MMCSDCard.h
fixes the error. But that's a dirty hack.Expected behavior
Build system should be aware of chip specific Smooth configurations and either provide documentation on how to disable unsupported libraries or use error-throwing mocks when underlying hardware/firmware aren't available.
Similar problems may probably arise with other compile target / library combinations.
The text was updated successfully, but these errors were encountered: