Fix qml.draw/_mpl to work with deferred measurements circuits that use MCMs in measurements
#5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mudit2812
commented
Apr 30, 2024
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.36.0-rc0 #5610 +/- ##
==============================================
Coverage ? 99.69%
==============================================
Files ? 412
Lines ? 38302
Branches ? 0
==============================================
Hits ? 38184
Misses ? 118
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
[sc-62204] |
astralcai
approved these changes
May 1, 2024
dwierichs
requested changes
May 1, 2024
There was a problem hiding this comment.
Nice, thanks for the quick fix @mudit2812 :)
Just one suggestion to cover the uncovered line within a test you added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
defer_measurementsleavesMeasurementValues in the terminal measurement processes if they are present. This is not friendly with the drawer as the classical wires for those measurement values do not exist when usingdefer_measurements. This PR adds a "hack" fix so that the drawer/MPL drawer work with this scenario.Description of the Change:
Add
transform_deferred_measurements_tapeutil function, which replaces anyMeasurementValues present in the tape after applyingdefer_measurementswith wires. This transform is only applied intape_textandtape_mpl.Benefits:
Drawer works better with MCMs
Possible Drawbacks:
Hacky fix, technical debt to implement cleaner fix later
Related GitHub Issues:
#5588