Fix decompositions with LightningQubit
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-61467] |
maliasadi
reviewed
Apr 16, 2024
Comment on lines
-185
to
-187
| "BasisState", | ||
| "QubitStateVector", | ||
| "StatePrep", |
There was a problem hiding this comment.
For the reference, these ops are also decomposed in Catalyst by default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/test_templates #687 +/- ##
=========================================================
Coverage ? 95.72%
=========================================================
Files ? 173
Lines ? 24507
Branches ? 0
=========================================================
Hits ? 23459
Misses ? 1048
Partials ? 0 ☔ View full report in Codecov by Sentry. |
1 task
mudit2812
changed the title
LightningQubitLightningQubit
maliasadi
reviewed
Apr 17, 2024
maliasadi
reviewed
Apr 17, 2024
maliasadi
reviewed
Apr 17, 2024
vincentmr
reviewed
Apr 17, 2024
maliasadi
reviewed
Apr 17, 2024
vincentmr
approved these changes
Apr 17, 2024
Co-authored-by: Ali Asadi <[email protected]>
maliasadi
approved these changes
Apr 17, 2024
maliasadi
added a commit
that referenced
this pull request
Apr 18, 2024
…ix LQ decomposition strategy of QFT and GroverOperator (#684) * Add test for QSVT. * Auto update version * Update changelog. * Add tests for embedding, layer and stateprep templates. * Parametrize tests over n_qubits. * Add qchem template tests. * Add a few misc template tests. * Auto update version * trigger ci * Fix serialize. * Fix formatting. * Update tests/test_templates.py Co-authored-by: Amintor Dusko <[email protected]> * Update tests/test_templates.py Co-authored-by: Amintor Dusko <[email protected]> * Add xfail condition for AmplitudeEmbedding. * Fix pytest.skip top cond. * Update tests/test_templates.py Co-authored-by: Ali Asadi <[email protected]> * Update pennylane_lightning/core/_serialize.py Co-authored-by: Ali Asadi <[email protected]> * Add breaking tests for if not observable * trigger ci * Auto update version * Fix decompositions with `LightningQubit` (#687) * Fix bug; add tests; update changelog * Auto update version * Update tests * Update qft/grover decomp * Addressing code review * Update pennylane_lightning/lightning_qubit/lightning_qubit.py Co-authored-by: Ali Asadi <[email protected]> * Trigger CI * Auto update version --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ali Asadi <[email protected]> * Fix test params --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amintor Dusko <[email protected]> Co-authored-by: Ali Asadi <[email protected]> Co-authored-by: Mudit Pandey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
PL Issue #5526. State prep operations in the middle of circuits were not being decomposed with
lightning.qubit.Description of the Change:
stopping_conditionto decomposeqml.QFTandqml.GroverOperatorif number of wires is >= 10 or 13 respectively.Benefits:
Feature parity with
default.qubit/oldlightning.qubit.Possible Drawbacks:
Related GitHub Issues: