Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The dtype for
qml.sample(Identity(0))
doesn't match the dtype for its eigvals, and it breaks JAX-JIT. Some observables useint
, some usefloat
, depending on the dtype ofeigvals
. We're opting to standardize this to be floats.Description of the Change:
Change eigvals of
X
,Y
,Z
andHadamard
to be floats. This will also affectTensor
, which previously wasint
if it was composed only of those observables.The generation of samples is modified in
_qubit_device
and onSampleMP
, because it wasn't actually using theeigvals
for these 4 operators.Benefits:
We can do this:
and we are less likely to have similar/related bugs in the future.
Possible Drawbacks:
Samples that used to be
int
will becomefloat
Related GitHub Issues:
#5369