Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Trap Cooldown for Trap Supported Spell in Black Zenith #7595

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Show Trap Cooldown for Trap Supported Spell in Black Zenith #7595

wants to merge 1 commit into from

Conversation

NL908
Copy link

@NL908 NL908 commented Apr 24, 2024

Fixes #7594

Description of the problem being solved:

  • When a projectile spell with no cooldown is supported by trap support in Black Zenith, the trap cooldown is not being counted and shown.

Steps taken to verify a working solution:

  • Load sample PoB
  • All trap skills socketed in Black Zenith should display trap cooldown
  • Trap with built-in cooldown should functions the same

Link to a build that showcases this PR:

https://pobb.in/0Mgib7TyTvw0

Before screenshot:

Stats1
Stats2

After screenshot:

Stats1
Stats2

@Paliak Paliak added the bug:calculation Numerical differences label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug:calculation Numerical differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trap Cooldown for Trap Supported Spell in Black Zenith
2 participants
@NL908 @Paliak