Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find-BicepNetModule gives error #318

Open
PalmEmanuel opened this issue Sep 11, 2023 · 2 comments
Open

Find-BicepNetModule gives error #318

PalmEmanuel opened this issue Sep 11, 2023 · 2 comments
Assignees

Comments

@PalmEmanuel
Copy link
Member

Describe the bug
Find-BicepNetModule (and corresponding PSBicep command) gives an error when running it, even when working.

image

To Reproduce
Steps to reproduce the behavior:

  1. Import the newest BicepNet version.
  2. Run Find-BicepNetModule -Cache

Additional context
image

@PalmEmanuel PalmEmanuel added bug Something isn't working dependency: BicepNet labels Sep 11, 2023
@SimonWahlin SimonWahlin self-assigned this Sep 27, 2023
@PalmEmanuel
Copy link
Member Author

PalmEmanuel commented Oct 22, 2023

The error no longer shows up, but that's because we simply ignore the included Microsoft Bicep repo as a quick fix. We should have a deeper look at what's causing it.

@SimonWahlin
Copy link
Member

Problem seems to be that mcr.microsoft.com responds with a HTML page that the ACR SDK tries to parse as JSON.

The bicep language server is downloading a module index which is uses for completions, the cache is dowloaded by the method private async Task<ImmutableArray?> TryGetModulesLive()

We might want to implement something similar in the future, until then, just ignoring MCR is good enough for now.

@SimonWahlin SimonWahlin added enhancement New feature or request Future milestone and removed bug Something isn't working labels Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants