Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noise formulas should not contain spaces #313

Open
FFroehlich opened this issue Feb 20, 2020 · 1 comment · May be fixed by #579
Open

Noise formulas should not contain spaces #313

FFroehlich opened this issue Feb 20, 2020 · 1 comment · May be fixed by #579

Comments

@FFroehlich
Copy link
Collaborator

specifying 'noiseFormula' as 'lambda reg' will make

https://github.com/ICB-DCM/AMICI/blob/16e3d762a94a35d21825f904d9d4381f82d117ab/python/amici/petab_import.py#L502

fail since sp.sympify('lambda reg'). I assume this will be a general issue and is not related to amici and that amici does sufficiently input check the provided petab.
@JanHasenauer
Copy link
Contributor

Is this implemented in the validation? if not, this would be important.

@dweindl dweindl linked a pull request May 23, 2024 that will close this issue
WIP: Specification of math expressions #579
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Specification of math expressions PEtab-dev/PEtab
2 participants
@JanHasenauer @FFroehlich