Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc: More DuckStation backports #11252

Merged
merged 23 commits into from
May 17, 2024
Merged

Misc: More DuckStation backports #11252

merged 23 commits into from
May 17, 2024

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented May 15, 2024 •
edited

Description of Changes

  • FullscreenUI: Fix gaps between some UI elements
  • FullscreenUI: Fix minimal output latency toggle
  • FullscreenUI: Add horizontal padding to menu windows
  • FullscreenUI: Use native file selector on Flatpak
  • Qt: Add option to pause when controller is disconnected
  • 3rdparty/cubeb: Sync to 19fcbef
  • 3rdparty/cubeb: Only include connected devices when enumerating wasapi
  • GS/Vulkan: Simplify loader using DynamicLibrary
  • SettingsInterface: Fix TinyString helper
  • Host: Add plural translation support
  • Error: Strip trailing whitespace from Windows errors
  • MTGS: Eliminate redundant SynchronousMTGS checks in Release build
  • Config: Remove redundant GS setting macros
  • GS: Make VSync a boolean toggle
  • InputManager: Add push to toggle for macros
  • AudioStream: Vectorize volume application
  • FullscreenUI: Warning fix
  • USB-Eyetoy: Fix unused comprLen warning
  • VMManager: Rewrite input profile hotkey priority logic
  • CI/AppImage: Don't bundle libssl/libcrypto

Rationale behind Changes

See commit list.
Closes #11242.
Closes #11237.
Closes #11230.

Suggested Testing Steps

  • Check Big Picture UI.
  • Test pause on controller disconnect (you'll need to actually have it bound to a virtual PS2 controller).
  • Check sound output.
  • Make sure Vulkan renderer still works.
  • Make sure VSync still works.
  • Test new push-to-toggle macro feature.
  • Check input profiles.
  • Make sure AppImage still runs.

@stenzek stenzek force-pushed the backports branch 2 times, most recently from a2513c3 to 979ae81 Compare May 15, 2024 14:00
stenzek added 11 commits May 16, 2024 18:35
@stenzek
FullscreenUI: Fix gaps between some UI elements
47a512a 
Backport of stenzek/duckstation@4d8ed49
stenzek/duckstation@69e0c16
@stenzek
FullscreenUI: Fix minimal output latency toggle
42f1bb6
@stenzek
FullscreenUI: Add horizontal padding to menu windows
dc503ed 
Backport of stenzek/duckstation@37a76a0
@stenzek
FullscreenUI: Use native file selector on Flatpak
f768216
@stenzek
Qt: Add option to pause when controller is disconnected
37e9e89
@stenzek
3rdparty/cubeb: Sync to 19fcbef
3fbf57a 
Backport of stenzek/duckstation@872cee9

And apply PR PCSX2#740 (Re-enable and polish IAudioClient3 to achieve lower
latencies).

`*latency_frames = min_period;` in wasapi_get_min_latency was changed to
`*latency_frames = hns_to_frames(params.rate, min_period_rt);`, as
otherwise it reports in mixer frames, not stream frames.
@stenzek
3rdparty/cubeb: Only include connected devices when enumerating wasapi
fff2fe8 
Otherwise you just get a ton of unusable outputs.
@stenzek
GS/Vulkan: Simplify loader using DynamicLibrary
ce12fb3 
Backport of stenzek/duckstation@8e3284d
@stenzek
SettingsInterface: Fix TinyString helper
ac21682 
Backport of stenzek/duckstation@d9003b1
@stenzek
Host: Add plural translation support
ff61482 
Backport of stenzek/duckstation@f3aec0c
@stenzek
Error: Strip trailing whitespace from Windows errors
9fa069a 
Backport of stenzek/duckstation@c85e743
stenzek added 12 commits May 16, 2024 19:06
@stenzek
MTGS: Eliminate redundant SynchronousMTGS checks in Release build
08e12b9
@stenzek
Config: Remove redundant GS setting macros
ffe6806 
Not needed without WX.
@stenzek
GS: Make VSync a boolean toggle
b16a41a 
i.e. ditch the old adaptive mode, and always use adaptive if available.
@stenzek
Misc: Pass most string_views by value instead of reference
40887c6
@stenzek
InputManager: Add push to toggle for macros
169814b 
Backport of stenzek/duckstation@f0a4ceb
@stenzek
AudioStream: Vectorize volume application
0f0edb5
@stenzek
FullscreenUI: Warning fix
c3450e8
@stenzek
USB-Eyetoy: Fix unused comprLen warning
9fd4793 
But this also has a behavioural change.
@stenzek
VMManager: Rewrite input profile hotkey priority logic
f741a73
@stenzek
CI/AppImage: Don't bundle libssl/libcrypto
c1a8bc6
@stenzek
Qt: Rename Load Profile to Apply Profile
df62611 
And make it copy hotkeys.
@stenzek
Qt: Update base translation
4d42b8a
@stenzek stenzek merged commit e8e84d1 into PCSX2:master May 17, 2024
11 of 12 checks passed
@stenzek stenzek deleted the backports branch May 17, 2024 01:57
@a931vwewi a931vwewi mentioned this pull request May 17, 2024
Closed
@bigol83
Copy link

bigol83 commented May 19, 2024

This change made it so around half my games are forced to have tearing, even with vsync option. I am a PAL user with many games that don't have an NTSC selector. If this is what caused it, please reconsider.

@a931vwewi a931vwewi mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamfretoz kamfretoz kamfretoz approved these changes

@Mrlinkwii Mrlinkwii Mrlinkwii approved these changes

@JordanTheToaster JordanTheToaster JordanTheToaster approved these changes

Assignees
No one assigned
Labels
Build | Project System CDVD Dependencies Pull requests that update a dependency file GS: Direct3D 11 GS: Direct3D 12 GS: Hardware GS: Metal GS: OpenGL GS: Vulkan GS GUI/Qt Memory Card PAD RetroAchievements Translations USB
Projects
None yet
Milestone
No milestone
5 participants
@stenzek @bigol83 @kamfretoz @Mrlinkwii @JordanTheToaster