Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in code to migrator to ensure collections get the proper permissions #2948

Open
straleyb opened this issue Sep 22, 2023 · 2 comments
Open
Assignees
Labels
Bug Post-migration Priority - High Issues that should be prioritized ahead of others - early timing in the project

Comments

@straleyb
Copy link
Contributor

Descriptive summary

When the migrator runs it create collections bypassing some other hyrax code. The code that is bypassed adds in the permissions which allow discoverability for the collections as well as autocomplete on the relationships tab when creating a new work. This code needs to be added into the migrator to allow this process to take place during migration instead of after.

Expected behavior

When the migrator runs, it adds the Repository Administrators group to the collection which you can see when editing the collection.

Related work

Work done on #2877

Accessibility Concerns

N/A

@straleyb straleyb added Bug Priority - High Issues that should be prioritized ahead of others - early timing in the project Post-migration labels Sep 22, 2023
@straleyb straleyb self-assigned this Sep 22, 2023
@straleyb straleyb moved this from Ready to In Progress in Enhancement Workcycle 2 Oct 11, 2023
@shieldsb shieldsb added this to In Progress in Enhancement Workcycle 3 Nov 9, 2023
@straleyb straleyb moved this from In Progress to QA in Enhancement Workcycle 3 Nov 13, 2023
@lsat12357
Copy link
Contributor

Some clarification: the migrator code was not responsible for creating collections, this was done with a rake task, see https://github.com/OregonDigital/OD2/blob/master/lib/tasks/oregon_digital/create_collections.rake, and Brandon has updated that code.

@lsat12357
Copy link
Contributor

lsat12357 commented Nov 16, 2023

QA Creating a single coll on staging. New instruction ran without incident once I remembered to save the coll; successfully added and removed the coll from a work.

@lsat12357 lsat12357 moved this from QA to Done in Enhancement Workcycle 3 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Post-migration Priority - High Issues that should be prioritized ahead of others - early timing in the project
Projects
No open projects
Development

No branches or pull requests

2 participants