-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Support for Loading Translations #11356
Labels
Milestone
Comments
It's a minor breaking change, I don't think many have implemented this. Maybe check if we have a breaking change label, and create it if not to add it to the PR. Also change the release instructions to check for this label and mention them in the release notes. |
Not sure about the NuGet packages though, it's not just Orchard CMS. |
hishamco
added
the
breaking change 💥
Issues or pull requests that introduces breaking change(s)
label
Mar 17, 2022
hishamco
removed
the
breaking change 💥
Issues or pull requests that introduces breaking change(s)
label
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While I'm working on DataLocalization support, I realize that
ITranslationProvider.LoadTranslations
should supportasync
for loading translations from database or any store without blocking.I know this will be a breaking change but it's good improvement for
2.0.0
The text was updated successfully, but these errors were encountered: