Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ODS dependency to Material vs Material 3 inconsistency #820

Open
1 task done
LaurentRenard opened this issue Feb 21, 2024 · 0 comments
Open
1 task done

[Bug]: ODS dependency to Material vs Material 3 inconsistency #820

LaurentRenard opened this issue Feb 21, 2024 · 0 comments
Assignees
Labels
🐞 bug Something isn't working

Comments

@LaurentRenard
Copy link

Prerequisites

Your test device

Any

OS Version

Any

App version

0.18

Describe the issue

Since Compose 2024.02.00, material3 ships with a new lint warning UsingMaterialAndMaterial3Libraries.
This warning is triggered during our app build on every import from material, due to ODS dependencies, and prevent the build to succeed :

import androidx.compose.material.Text
Error: Using a material import while also using the material3 library [UsingMaterialAndMaterial3Libraries from androidx.compose.material3]

The description of the lint warning is self explanatory:

Explanation for issues of type "UsingMaterialAndMaterial3Libraries":
material and material3 are separate design system libraries that are
incompatible with each other
, as they have their own distinct theming
systems. Using components from both libraries concurrently can cause
issues: for example material components will not pick up the correct
content color from a material3 container, and vice versa.

While we might de-activate this lint check, this one is definitely too severe to ignore.

Expected Behavior

ODS shall depend on / be built upon either Material design system or Material3, but cannot depend on both as they present different contracts to the app

@LaurentRenard LaurentRenard added 🐞 bug Something isn't working 🔍 triage A new issue that needs to be treated labels Feb 21, 2024
@paulinea paulinea added v1.0 and removed 🔍 triage A new issue that needs to be treated labels Mar 5, 2024
@paulinea paulinea added this to Triage in 🟢 Sprint 28 - Feb 2024 via automation Mar 5, 2024
@paulinea paulinea moved this from Triage to Ready to dev in 🟢 Sprint 28 - Feb 2024 Mar 5, 2024
@paulinea paulinea removed the v1.0 label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Development

No branches or pull requests

3 participants