-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existing dynamic keyboards broken on origin/master #868
Comments
@kmcnaught So, basically, you would either need to have your Back key somewhere before your Clear key, or you would need to assign a row to your "Clear" to tell the algorithm to start filling a different row, and then when it gets to your Back key it will jump backwards to that position and start filling adjacent empty space from there. All that said, I could probably make it allocate space for certain keys, but also include them as logical "move to indicators" when the full list of keys is processed in order. |
@kmcnaught This commit fixes that issue, but a lot of other stuff is still in progress. With it, I loaded your keyboard into my designer and then saved it with my current schema to the attached file. |
The commit: 25f5d16 breaks one of my existing keyboards. @AdamRoden was it supposed to introduce any functional changes?
Keyboard file - vscode.txt
Before 25f5d16, this keyboard loads like this:
After 25f5d16, I get the error "insufficient space to position item 17 of 81 with symbol "BackIcon" at row 0 column 15"
(Note that some of the keys won't work as I've added some functionality in a separate branch, I'm just interested in whether it loads okay)
The text was updated successfully, but these errors were encountered: