-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make warning #7
Comments
I was looking at this code to see why it was using mktemp, but it looks like it has a couple of issues:
The strncat ".xml" is never used so it should probably just be dropped. Modifying the temporary filename doesn't seem like a great idea anyway. So the other problem is that fn is a char pointer where mkstemp needs an integer since it returns a filehandle instead of a name. That's no big deal because mkstemp will modify the buffer internally and return it. You've got an unneeded filehandle returned, but you can deal with that in a couple of ways. You could modify doc.Savefile to accept descriptors instead of names, or just close it. |
thanks. I'll look into this eventually. |
Original issue reported on code.google.com by
[email protected]
on 28 Dec 2012 at 4:03The text was updated successfully, but these errors were encountered: