Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamPropertyChanged not being raised neither on Publisher nor on Session #795

Open
kazepis opened this issue Mar 23, 2023 · 3 comments
Open
Labels

Comments

@kazepis
Copy link

kazepis commented Mar 23, 2023

Describe the bug
streamPropertyChanged is not being raised neither on Publisher nor on Session when sharing application window is resized

Expected behavior
The 'streamPropertyChanged' should be raised on both the Publisher and the Session

Wrong current behavior
The browser (chrome) console window shows the following log:
Sending request: {method:"streamPropertyChanged", params: {"streamId":"str_SCR_KLwZ_con_I8pXNA23GH","property":"videoDimensions","newValue":"{\"width\":430,\"height\":816}","reason":"screenResized"}}
But the streamPropertyChanged event is not raised

OpenVidu deployment info
How is your OpenVidu Server instance deployed when you get the bug. A couple of possible examples are listed below:

  • Docker container docker run --hostname=362e3a0807b7 --mac-address=02:42:ac:11:00:02 --env=OPENVIDU_SECRET=1234 --env=OPENVIDU_RECORDING=true --env=OPENVIDU_RECORDING_PATH=/opt/openvidu/recordings --env=PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin --volume=/var/run/docker.sock:/var/run/docker.sock --volume=C:\OpenViduRecordings:/opt/openvidu/recordings -p 4443:4443 --restart=no --label='maintainer=[email protected]' --runtime=runc -d openvidu/openvidu-dev:2.25.0

Client device info (if applicable)
Describe the client device(s) or platform(s) where you are able to replicate the error. For example:

  • Chrome Version 111.0.5563.110 (Official Build) (64-bit) on Windows 10.
@kazepis kazepis added the bug label Mar 23, 2023
@kazepis
Copy link
Author

kazepis commented Mar 23, 2023

image
The breakpoints in the callback function are never being hit.
The sendRequest in line 647 is executed.

@pabloFuente
Copy link
Member

If streamPropertyChanged event is not being triggered by the local Publisher or Session object, then it means that the sendRequest method is not finishing correctly. Furthermore, I think that the operation is hanging somehow, because even if it failes (let's imagine becasue of an incompatibility between openvidu-browser and the OpenVidu deployment versions), the operation should log the error line. The problem could be related to a network issue with the OpenVidu deployment? But in this case it would be very strange that the error only happens with this RPC operation and not others.

@vsx-sieber
Copy link

I am currently working on a Unity C# port of the openvidu-browser library and just stumbled upon this piece of code and was wondering: Does Openvidu server even listen to streamPropertyChanged events coming from the client? Your RPC reference does not mention this kind of "Client-Server method". Its only mentioned as a "Server event" originating from and emitted by the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants