Adding a sanity test in 'exists(path)' function #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
There is at least one error type (
ECONNRESET) in request that causes responses to be null. This will cause an uncaught error in the following line whenever this error occurs:npm-WebDAV-Client/src/index.ts
Line 287 in ba7280b
Fix
Tests if any error is returned by the request before accessing the
statusCodeof the response.Warning
This PR changes the signature of the callback in this function from:
(error : Error, exists : boolean)to(error : Error, exists ?: boolean). Which means that if an error occurs, the boolean will not be returned!!!closes #14