-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feign-micrometer: spanId/parentId information lost #2316
Comments
I do have the same issue. I do have Spring Cloud Gateway running and behind that several microservices. To all projects, I added the dependencies The feign client is generated via the OpenAPI Generator from a swagger file. What do i miss here? |
I had the same issue some weeks ago. Adding a TaskDecorator Bean and setting it to the taskDecorator of the threadPoolTaskExecutor Bean worked for me. @Bean
fun taskDecorator(): TaskDecorator {
return TaskDecorator { runnable: Runnable? ->
ContextSnapshot.captureAll(*arrayOfNulls(0)).wrap(
runnable!!,
)
}
}
@Bean
fun threadPoolTaskExecutor(): ThreadPoolTaskExecutor = ThreadPoolTaskExecutor().apply {
setTaskDecorator(taskDecorator())
} |
Hi all,
We are logging the outgoing FeignClient requests in our Spring Boot applications.
These logs include traceId, spanId and parentId.
On the called service side the same information gets logged (e.g. when logging the incoming HTTP request).
Since the migration to micrometer (i.e. Spring Boot 2.7 to Spring Boot 3.1/3.2 migration) the "chain of spanId" is missing.
Note: a sample application with minimal dependencies has been created to demonstrate the issue.
The sample app provides a
/doit
endpoint which invokes its second endpoint/execute
using a FeignClient.in Spring Boot 2.7
Previous to the migration to micrometer it used to look like:
Where the parentId on the called server side is equals to the spanId logged on the client side. In the example above:
ac648962656d9825
in Spring Boot 3.2
After the migration to micrometer i.e. Spring Boot 3.1/3.2 it looks like:
Where the spanId
9361afdcea28771e
logged on the client side is not present in the log on the server side.Can this be configured?
How can we get the whole "chain of spanId" back?
It is very important to us so we can chain the logs correctly together.
Please find 2 samples in the attachment:
Just start the Spring Boot app and call the
/doit
endpoint:Kind regards,
Valentin
The text was updated successfully, but these errors were encountered: