-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about tracker.py & performance #167
Comments
Hi, @YTEP-ZHI I actually insert a assert False in the if,as below:
And it didn't goes wrong. so Is it possible we can remove this code? or is something wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi ! Thanks for your great work.
After reading your paper, I was interested in the performance of UniAD. And I used nvidia Nsight System to profile the model and found there is a period which both compute and memory throughput is very low. (only about 5%).
And The stack trace shows it might be something perform inefficiently with ~/UniAD/projects/mmdet3d_plugin/uniad/dense_heads/track_head_plugin/tracker.py。
I look into the code and found somthing i can't understand: the parameter "iou_thre" is set to be None and also passed None when the function is called.
And within this function it doesn't update iou_thre. So what's the point of parameter "iou_thre" and the code following
if iou_thre is not None
...Is there somthing I missed? Can You help me? Thanks a lot! (ps: This is my first time to write a issue, so feel free to point out any mistakes or stupid things i have done. Thx).
The following is the result of performance from the overall view
The text was updated successfully, but these errors were encountered: