Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for sandboxes #1431

Closed
xingyaoww opened this issue Apr 28, 2024 · 1 comment
Closed

Add unit tests for sandboxes #1431

xingyaoww opened this issue Apr 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@xingyaoww
Copy link
Collaborator

What problem or use case are you trying to solve?

I found DockerSSHBox does not work well with multi-line commands, we should add unit tests to cover these cases.

Describe the UX of the solution you'd like

tests/unit/test_sandbox.py

Do you have thoughts on the technical implementation?

Adding tests is pretty straight forward, but we should better handle how to starts each unit test with the correct config (i.e., correct UID, correct workspace to mount to, etc).

Describe alternatives you've considered

Additional context

@rbren
Copy link
Collaborator

rbren commented May 2, 2024

We have unit tests now! Thanks Xingyao!

@rbren rbren closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants