Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinions creation spins forever if you have mandatory marking definitions and you don't have any for the user #7104

Closed
SamuelHassine opened this issue May 23, 2024 · 2 comments
Assignees
Labels
question Further information is requested solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@SamuelHassine
Copy link
Member

Description

Opinions creation spins forever if you have mandatory marking definitions and you don't have it for the user

  1. Put marking definition as mandatory for opinion
  2. Login with a user that have a group with no default marking definition
  3. Try to create an opinion in an entity

=> Spinning for ever (should raise an error)

@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels May 23, 2024
@SamuelHassine SamuelHassine added this to the Bugs backlog milestone May 23, 2024
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label May 24, 2024
@marieflorescontact marieflorescontact self-assigned this May 27, 2024
@marieflorescontact
Copy link
Member

marieflorescontact commented May 27, 2024

I can't reproduce on my side, I have the expected error @nino-filigran :

UI:
image

Back:
{ "errors": [ { "message": "Validation error", "name": "VALIDATION_ERROR", "time_thrown": "2024-05-27T08:03:44.648Z", "data": { "http_status": 500, "genre": "BUSINESS", "field": "objectMarking", "message": "This attribute is mandatory", "attribute": "objectMarking" } } ], "data": { "opinionAdd": null } }

@marieflorescontact marieflorescontact added the needs more info Intel needed about the use case label May 27, 2024
@nino-filigran
Copy link

Agreed, just retried again on testing and I have the same result, which is the desired behavior. I don't know what changed.

@nino-filigran nino-filigran added wontfix use to identify issue that won’t be worked on and removed needs more info Intel needed about the use case labels May 27, 2024
@SamuelHassine SamuelHassine removed this from the Bugs backlog milestone May 27, 2024
@SamuelHassine SamuelHassine added question Further information is requested solved use to identify issue that has been solved (must be linked to the solving PR) and removed bug use for describing something not working as expected wontfix use to identify issue that won’t be worked on labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

3 participants