Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning messages on report entities and observables tabs + translations (#7073) #7095

Merged
merged 2 commits into from
May 27, 2024
Merged

Add warning messages on report entities and observables tabs + translations (#7073) #7095

merged 2 commits into from
May 27, 2024

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • Add warning messages on report entities and observables tabs
  • Translations of those messages

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label May 23, 2024
@lndrtrbn lndrtrbn self-assigned this May 23, 2024
@lndrtrbn lndrtrbn added this to the Release 6.2.0 milestone May 23, 2024
@lndrtrbn lndrtrbn linked an issue May 23, 2024 that may be closed by this pull request
Missing warning before deletions of entity in container #7073
Closed
@lndrtrbn lndrtrbn removed this from the Release 6.2.0 milestone May 23, 2024
@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (e58bac2) to head (3430154).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7095   +/-   ##
=======================================
  Coverage   67.58%   67.59%           
=======================================
  Files         561      561           
  Lines       68738    68738           
  Branches     5837     5839    +2     
=======================================
+ Hits        46456    46461    +5     
+ Misses      22282    22277    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marieflorescontact
marieflorescontact approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@lndrtrbn lndrtrbn merged commit bc8f0bb into master May 27, 2024
5 checks passed
@lndrtrbn lndrtrbn deleted the issue/7073 branch May 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieflorescontact marieflorescontact marieflorescontact approved these changes

Assignees

@lndrtrbn lndrtrbn

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing warning before deletions of entity in container
2 participants
@lndrtrbn @marieflorescontact