-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ] Switch deprecated retrofit2-kotlinx-serialization-converter for first party kotlinx-serialization #18593
Comments
thanks for opening an issue (ticket) to track this. the switch sounds good may I know if you've time to contribute a PR for that? let me know if you need some good starting points. |
Yeah, that would not be a problem. A preliminary timeline when I'd be available to contribute it would be early-mid next week. Sure, I've had a look at blame for earlier similar contributions, as well as the CONTRIBUTING guidelines, but if theres some other goodies that would be helpful to me, please don't hesitate. |
yup, previous PRs would be a good starting point too. look forward to your PR. thanks in advance for your contributions |
The pr was merged, so ill close this REQ now |
Is your feature request related to a problem? Please describe.
Back in the middle of march 2024 jakewharton retrofit2-kotlinx-serialization-converter was deprecated as it was moved to a first party converter. This means that any further improvements to the converter will happen in the retrofit repository.
Describe the solution you'd like
Switch out the retrofit converter factory used for kotlinx_serialization with the new first party converter.
Describe alternatives you've considered
Given that no further development is to be expected on the deprecated repository, and the fact that the repo was moved to a first party converter with no code changes between, I don't see any other clear options.
The text was updated successfully, but these errors were encountered: