Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of PK-Sim module conversion to extension module #2239

Open
rwmcintosh opened this issue May 3, 2024 · 0 comments
Open

Improve handling of PK-Sim module conversion to extension module #2239

rwmcintosh opened this issue May 3, 2024 · 0 comments
Milestone

Comments

@rwmcintosh
Copy link
Member

We have implemented something for warning a user when a module is converted from PK-Sim to an extension module.

The implementation just warns the user any time a building block version number is updated. This is also how we are testing for whether a module is PK-Sim or not. If any of the module building blocks does not have the same version as created in PK-Sim, then it's not a PK-Sim module.

There are a couple problems with this implementation

  1. The test in version updater is very low level in the call chain and is executed during command execution. If possible, it should happen before, and allow user to cancel.
  2. Not all changes to a building block render the module as extension module. Eg. if you change a building block name, it should remain a PK-Sim module.

Some analysis needs to be done to separate what commands really mean the module is extension module.

@rwmcintosh rwmcintosh added this to the OSMOSES vNext milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant