Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create a simulation from BBs after opening a V11 project #1354

Open
PavelBal opened this issue May 28, 2024 · 9 comments
Open

Cannot create a simulation from BBs after opening a V11 project #1354

PavelBal opened this issue May 28, 2024 · 9 comments
Assignees

Comments

@PavelBal
Copy link
Member

Trying to re-configure a simulation or create a new from existing modules, I get the error:

image

@Yuri05
Copy link
Member

Yuri05 commented Jun 7, 2024

It seems that formulasAreTheSameForParameter() called here (s. the screenshot) does not work correctly

Calling formulasAreTheSameForParameter()

grafik

The neighborhood keywords are not replaced here:

grafik

Those specific keywords are expanded not in KeywordReplacer but in the FormulaTask.

I tried to fix it by calling the proper method from the FormulaTask:

grafik

But this failed:
grafik

Not sure how to proceed. Maybe @msevestre can comment on this?

@msevestre
Copy link
Member

I am getting this error now:

@PavelBal
Does this makes sense to you
image

@msevestre
Copy link
Member

indeed Albumin is not in the neighbhorhoods
image

1 similar comment
@msevestre
Copy link
Member

indeed Albumin is not in the neighbhorhoods
image

@PavelBal
Copy link
Member Author

Albumin is not present in the Intracellular compartments:

image

So it should not be present in this neighborhood. The weird thing is that Organism|xxx|Interstitial|Albumin|Partition coefficient (water/container) for albumin is calculated by the formula, though it is defined in the PV BB

image

So the PV BB is not properly applied.

@PavelBal
Copy link
Member Author

Okay, this is happening because every BB has been put into a separate module. So when creating a simulation, the parameter is first calculated by the equation and only later is overwritten by the fixed value stored in the PV.

I have updated the MoBi project in the repo and put all the required BBs (except for the Reactions because of #1376) in the "Spatial Stucture" module. Trying to create a simulation from the modules "Spatial Structure" and "Reaction" will give the initial error about "another formula for parameter"

image

@msevestre
Copy link
Member

Okay, this is happening because every BB has been put into a separate module. So when creating a simulation, the parameter is first calculated by the equation and only later is overwritten by the fixed value stored in the PV.

I don't understand this. BB in one module works but BB in different module does not?

@msevestre
Copy link
Member

I am getting another error
image

I think I have fixed the issue but this simplify project just does not work at all

@PavelBal
Copy link
Member Author

Yes this is something else. I simplified the project too much.. I think your fix will work, once it is merged I will try it with this project and update it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Accepted
Development

No branches or pull requests

3 participants