-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting 'Invalid pinpoint' errors with alternate tree. Should life.html be tree agnostic? #829
Comments
AFAIK there isn't a solid plan for how we add multiple trees to the site architecture. The locations aren't just dependent on tree---but one of the reasons the list is here is we also customise this list for other pages, e.g: AT.html and otop.html. I think the idea was to let partners customise their own page, including their start points. Moving The other reason is to avoid a database hit, but IMO we should get better at caching rather than worry too much about that, given ~all our pages are anonymous. In the short term we could have a "custom.html" that makes no assumptions about the tree it's using? |
You're right that we'll probably end up having a custom locations_json for the extinct tree. From a maintenance standpoint, I see there are 8 files with identical We don't need to do anything short term, but it feels like the right solution is to better decouple 'code' from 'data', but having things like |
If I run with my alternate tree, I see these errors in F12 (note: the site still seems to run ok):
They're caused by the hard coded
locations_json
list in life.html.This brings the question: is life.html meant to be specific to the main tree? Ot should we try to have
locations_json
be populated more dynamically, like from configuration?The text was updated successfully, but these errors were encountered: